Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL support section to BigQuery connector #8923

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

Jessie212
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2021
docs/src/main/sphinx/connector/bigquery.rst Show resolved Hide resolved
docs/src/main/sphinx/connector/bigquery.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/bigquery.rst Outdated Show resolved Hide resolved
@ebyhr ebyhr added the docs label Aug 20, 2021
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a minor comment.

Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@hashhar hashhar added this to the 361 milestone Aug 23, 2021
@hashhar hashhar merged commit b050b64 into trinodb:master Aug 23, 2021
@Jessie212 Jessie212 deleted the bigquery-sql-support branch January 25, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants